build: add .bazelrc to disable Python toolchains#2535
Merged
Conversation
Summary: This expands our forward-compatibility window to at least 0.29.0rc4 by opting out of the `--incompatible_use_python_toolchains` flag whose default was flipped in 0.27.0 (see #2355). Test Plan: On Bazel 0.29.0rc4, verify that `//tensorboard` builds and runs correctly and that all tests pass, without the need to manually specify any flags to Bazel. wchargin-branch: bazelrc-toolchains
stephanwlee
approved these changes
Aug 9, 2019
nfelt
reviewed
Aug 9, 2019
.bazelrc
Outdated
| @@ -0,0 +1 @@ | |||
| common --incompatible_use_python_toolchains=false | |||
Contributor
There was a problem hiding this comment.
Maybe let's add a comment referencing the issue that requires this?
wchargin-source: 1c1d54469ce7d63c1b8415eb3d1511958ed63aa5 wchargin-branch: bazelrc-toolchains
This was referenced Aug 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This expands our forward-compatibility window to at least 0.29.0rc4 by
opting out of the
--incompatible_use_python_toolchainsflag whosedefault was flipped in 0.27.0 (see #2355).
Fixes #2534.
Test Plan:
On Bazel 0.29.0rc4, verify that
//tensorboardfetches, builds, andruns correctly and that all tests pass, without the need to manually
specify any flags to Bazel.
wchargin-branch: bazelrc-toolchains